diff --git a/scripts/preserve-update-feeds.py b/scripts/preserve-update-feeds.py index ff6131a..5053cc0 100644 --- a/scripts/preserve-update-feeds.py +++ b/scripts/preserve-update-feeds.py @@ -5,7 +5,7 @@ import json from pathlib import Path from urllib.error import HTTPError from urllib.parse import urlparse -from urllib.request import urlopen +from urllib.request import Request, urlopen import xml.etree.ElementTree as ET FEEDS = ("appcast.xml", "latest.json", "windows/latest.json", "windows/stable/appcast.xml", "windows/snapshot/appcast.xml") @@ -18,7 +18,9 @@ def preserve(base_url: str, directory: Path, exclude: list[str]) -> None: if relative in exclude: continue try: - with urlopen(base_url.rstrip("/") + "/" + relative, timeout=30) as response: + request = Request(base_url.rstrip("/") + "/" + relative, + headers={"User-Agent": "GPConnectReleasePublisher/1.0"}) + with urlopen(request, timeout=30) as response: data = response.read(1024 * 1024 + 1) except HTTPError as error: if error.code == 404: diff --git a/scripts/tests/test_windows_update_feed.py b/scripts/tests/test_windows_update_feed.py index 5996efa..6ac8f3b 100644 --- a/scripts/tests/test_windows_update_feed.py +++ b/scripts/tests/test_windows_update_feed.py @@ -187,6 +187,9 @@ class WindowsFeedTests(unittest.TestCase): ["appcast.xml", "latest.json", "windows/stable/appcast.xml", "windows/snapshot/appcast.xml"]) self.assertTrue((root / "windows/latest.json").exists()) self.assertEqual(request.call_count, 1) + outgoing = request.call_args.args[0] + self.assertEqual(outgoing.full_url, "https://updates.gpgui.com/windows/latest.json") + self.assertEqual(outgoing.get_header("User-agent"), "GPConnectReleasePublisher/1.0") with patch.object(preserver, "urlopen", side_effect=HTTPError("url", 500, "failure", {}, None)): with self.assertRaises(HTTPError): preserver.preserve("https://updates.gpgui.com", root, [])