cassidy/GlobalProtect-openconnect
1
0
Fork 0
mirror of https://github.com/yuezk/GlobalProtect-openconnect.git synced 2025-04-02 18:31:50 -04:00
Code Issues Projects Releases Wiki Activity

Properly handle gateway responses that return Javascript errors (#74)

Browse Source 
This was previously causing a segmentation fault, as the gateway
response would not be valid XML to be parsed.

Closes: #38, #71
This commit is contained in:
Tom Almeida 2021-08-03 22:17:50 +08:00 committed by GitHub
parent 3495dbfe18
commit 260b557238
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
GPClient/gatewayauthenticator.cpp
View File

@ -44,8 +44,9 @@ void GatewayAuthenticator::login(const LoginParams &params)
void GatewayAuthenticator::onLoginFinished() void GatewayAuthenticator::onLoginFinished()
{ {
QNetworkReply *reply = qobject_cast<QNetworkReply*>(sender()); QNetworkReply *reply = qobject_cast<QNetworkReply*>(sender());
QByteArray response;
if (reply->error()) { if (reply->error() || (response = reply->readAll()).contains("Authentication failure")) {
PLOGE << QString("Failed to login the gateway at %1, %2").arg(loginUrl).arg(reply->errorString()); PLOGE << QString("Failed to login the gateway at %1, %2").arg(loginUrl).arg(reply->errorString());
if (normalLoginWindow) { if (normalLoginWindow) {
@ -61,7 +62,7 @@ void GatewayAuthenticator::onLoginFinished()
normalLoginWindow->close(); normalLoginWindow->close();
} }
const QUrlQuery params = gpclient::helper::parseGatewayResponse(reply->readAll()); const QUrlQuery params = gpclient::helper::parseGatewayResponse(response);
emit success(params.toString()); emit success(params.toString());
} }