Add more logs to debug the portal login (#16)

GPClient/gatewayauthenticator.cpp

@@ -23,6 +23,8 @@ GatewayAuthenticator::~GatewayAuthenticator()
 
 void GatewayAuthenticator::authenticate()
 {
+    PLOGI << "Start gateway authentication...";
+
     LoginParams params;
     params.setUser(portalConfig.username());
     params.setPassword(portalConfig.password());
@@ -118,6 +120,8 @@ void GatewayAuthenticator::normalAuth(QString labelUsername, QString labelPasswo
 
 void GatewayAuthenticator::onPerformNormalLogin(const QString &username, const QString &password)
 {
+    PLOGI << "Start to perform normal login...";
+
     normalLoginWindow->setProcessing(true);
     LoginParams params;
     params.setUser(username);

GPClient/gpclient.cpp

@@ -97,6 +97,8 @@ void GPClient::initVpnStatus() {
 
 void GPClient::populateGatewayMenu()
 {
+    PLOGI << "Populating the Switch Gateway menu...";
+
     const QList<GPGateway> gateways = allGateways();
     gatewaySwitchMenu->clear();
 
@@ -200,6 +202,8 @@ void GPClient::onGatewayChanged(QAction *action)
 
 void GPClient::doConnect()
 {
+    PLOGI << "Start connecting...";
+
     const QString btnText = ui->connectButton->text();
     const QString portal = this->portal();
 
@@ -214,16 +218,19 @@ void GPClient::doConnect()
 
         // Login to the previously saved gateway
         if (!currentGateway().name().isEmpty()) {
+            PLOGI << "Start gateway login using the previously saved gateway...";
             isQuickConnect = true;
             gatewayLogin();
         } else {
             // Perform the portal login
+            PLOGI << "Start portal login...";
             portalLogin();
         }
     } else {
+        PLOGI << "Start disconnecting the VPN...";
+
         ui->statusLabel->setText("Disconnecting...");
         updateConnectionStatus(VpnStatus::pending);
-
         vpn->disconnect();
     }
 }
@@ -246,7 +253,10 @@ void GPClient::portalLogin()
 
 void GPClient::onPortalSuccess(const PortalConfigResponse portalConfig, const GPGateway gateway, QList<GPGateway> allGateways)
 {
+    PLOGI << "Portal authentication succeeded.";
+
     this->portalConfig = portalConfig;
+
     setAllGateways(allGateways);
     setCurrentGateway(gateway);
 
@@ -283,6 +293,8 @@ void GPClient::onPortalFail(const QString &msg)
 // Login to the gateway
 void GPClient::gatewayLogin()
 {
+    PLOGI << "Performing gateway login...";
+
     GatewayAuthenticator *gatewayAuth = new GatewayAuthenticator(currentGateway().address(), portalConfig);
 
     connect(gatewayAuth, &GatewayAuthenticator::success, this, &GPClient::onGatewaySuccess);
@@ -341,7 +353,6 @@ bool GPClient::connected() const
     return statusText.contains("Connected") && !statusText.contains("Not");
 }
 
-
 QList<GPGateway> GPClient::allGateways() const
 {
     const QString gatewaysJson = settings::get(portal() + "_gateways").toString();
@@ -350,6 +361,8 @@ QList<GPGateway> GPClient::allGateways() const
 
 void GPClient::setAllGateways(QList<GPGateway> gateways)
 {
+    PLOGI << "Updating all the gateways...";
+
     settings::save(portal() + "_gateways", GPGateway::serialize(gateways));
     populateGatewayMenu();
 }
@@ -368,6 +381,8 @@ GPGateway GPClient::currentGateway() const
 
 void GPClient::setCurrentGateway(const GPGateway gateway)
 {
+    PLOGI << "Updating the current gateway to " << gateway.name();
+
     settings::save(portal() + "_selectedGateway", gateway.name());
     populateGatewayMenu();
 }

GPClient/gphelper.cpp

@@ -23,10 +23,13 @@ QNetworkReply* gpclient::helper::createRequest(QString url, QByteArray params)
 
 GPGateway gpclient::helper::filterPreferredGateway(QList<GPGateway> gateways, const QString ruleName)
 {
+    PLOGI << gateways.size() << " gateway(s) avaiable, filter the gateways with rule: " << ruleName;
+
     GPGateway gateway = gateways.first();
 
     for (GPGateway g : gateways) {
         if (g.priorityOf(ruleName) > gateway.priorityOf(ruleName)) {
+            PLOGI << "Find a preferred gateway: " << g.name();
             gateway = g;
         }
     }
@@ -36,6 +39,8 @@ GPGateway gpclient::helper::filterPreferredGateway(QList<GPGateway> gateways, co
 
 QUrlQuery gpclient::helper::parseGatewayResponse(const QByteArray &xml)
 {
+    PLOGI << "Start parsing the gateway response...";
+
     QXmlStreamReader xmlReader{xml};
     QList<QString> args;
 

GPClient/loginparams.cpp

@@ -26,32 +26,32 @@ LoginParams::~LoginParams()
 {
 }
 
-void LoginParams::setUser(const QString &user)
+void LoginParams::setUser(const QString user)
 {
     updateQueryItem("user", user);
 }
 
-void LoginParams::setServer(const QString &server)
+void LoginParams::setServer(const QString server)
 {
     updateQueryItem("server", server);
 }
 
-void LoginParams::setPassword(const QString &password)
+void LoginParams::setPassword(const QString password)
 {
     updateQueryItem("passwd", password);
 }
 
-void LoginParams::setUserAuthCookie(const QString &cookie)
+void LoginParams::setUserAuthCookie(const QString cookie)
 {
     updateQueryItem("portal-userauthcookie", cookie);
 }
 
-void LoginParams::setPrelogonAuthCookie(const QString &cookie)
+void LoginParams::setPrelogonAuthCookie(const QString cookie)
 {
     updateQueryItem("portal-prelogonuserauthcookie", cookie);
 }
 
-void LoginParams::setPreloginCookie(const QString &cookie)
+void LoginParams::setPreloginCookie(const QString cookie)
 {
     updateQueryItem("prelogin-cookie", cookie);
 }
@@ -61,7 +61,7 @@ QByteArray LoginParams::toUtf8() const
     return params.toString().toUtf8();
 }
 
-void LoginParams::updateQueryItem(const QString &key, const QString &value)
+void LoginParams::updateQueryItem(const QString key, const QString value)
 {
     if (params.hasQueryItem(key)) {
         params.removeQueryItem(key);

GPClient/loginparams.h

@@ -9,19 +9,19 @@ public:
     LoginParams();
     ~LoginParams();
 
-    void setUser(const QString &user);
+    void setUser(const QString user);
-    void setServer(const QString &server);
+    void setServer(const QString server);
-    void setPassword(const QString &password);
+    void setPassword(const QString password);
-    void setUserAuthCookie(const QString &cookie);
+    void setUserAuthCookie(const QString cookie);
-    void setPrelogonAuthCookie(const QString &cookie);
+    void setPrelogonAuthCookie(const QString cookie);
-    void setPreloginCookie(const QString &cookie);
+    void setPreloginCookie(const QString cookie);
 
     QByteArray toUtf8() const;
 
 private:
     QUrlQuery params;
 
-    void updateQueryItem(const QString &key, const QString &value);
+    void updateQueryItem(const QString key, const QString value);
 };
 
 #endif // LOGINPARAMS_H

GPClient/portalauthenticator.cpp

@@ -46,6 +46,9 @@ void PortalAuthenticator::onPreloginFinished()
     PLOGI << "Portal prelogin succeeded.";
 
     preloginResponse = PreloginResponse::parse(reply->readAll());
+
+    PLOGI << "Finished parsing the prelogin response. The region field is: " << preloginResponse.region();
+
     if (preloginResponse.hasSamlAuthFields()) {
         // Do SAML authentication
         samlAuth();
@@ -178,14 +181,16 @@ void PortalAuthenticator::onFetchConfigFinished()
     }
 
     PLOGI << "Fetch the portal config succeeded.";
-
     PortalConfigResponse response = PortalConfigResponse::parse(reply->readAll());
+
     // Add the username & password to the response object
     response.setUsername(username);
     response.setPassword(password);
 
     // Close the login window
     if (normalLoginWindow) {
+        PLOGI << "Closing the NormalLoginWindow...";
+
         // Save the credentials for reuse
         settings::save("username", username);
         settings::save("password", password);

GPClient/portalconfigresponse.cpp

@@ -15,8 +15,10 @@ PortalConfigResponse::~PortalConfigResponse()
 {
 }
 
-PortalConfigResponse PortalConfigResponse::parse(const QByteArray& xml)
+PortalConfigResponse PortalConfigResponse::parse(const QByteArray xml)
 {
+    PLOGI << "Start parsing the portal configuration...";
+
     QXmlStreamReader xmlReader(xml);
     PortalConfigResponse response;
     response.setRawResponse(xml);
@@ -27,18 +29,22 @@ PortalConfigResponse PortalConfigResponse::parse(const QByteArray& xml)
         QString name = xmlReader.name().toString();
 
         if (name == xmlUserAuthCookie) {
+            PLOGI << "Start reading " << name;
             response.setUserAuthCookie(xmlReader.readElementText());
         } else if (name == xmlPrelogonUserAuthCookie) {
+            PLOGI << "Start reading " << name;
             response.setPrelogonUserAuthCookie(xmlReader.readElementText());
         } else if (name == xmlGateways) {
             response.setAllGateways(parseGateways(xmlReader));
         }
     }
 
+    PLOGI << "Finished parsing portal configuration.";
+
     return response;
 }
 
-const QByteArray& PortalConfigResponse::rawResponse() const
+const QByteArray PortalConfigResponse::rawResponse() const
 {
     return _rawResponse;
 }
@@ -55,6 +61,8 @@ QString PortalConfigResponse::password() const
 
 QList<GPGateway> PortalConfigResponse::parseGateways(QXmlStreamReader &xmlReader)
 {
+    PLOGI << "Start parsing the gateways from portal configuration...";
+
     QList<GPGateway> gateways;
 
     while (xmlReader.name() != xmlGateways || !xmlReader.isEndElement()) {
@@ -69,11 +77,16 @@ QList<GPGateway> PortalConfigResponse::parseGateways(QXmlStreamReader &xmlReader
             gateways.append(g);
         }
     }
+
+    PLOGI << "Finished parsing the gateways.";
+
     return gateways;
 }
 
 QMap<QString, int> PortalConfigResponse::parsePriorityRules(QXmlStreamReader &xmlReader)
 {
+    PLOGI << "Start parsing the priority rules...";
+
     QMap<QString, int> priorityRules;
 
     while (xmlReader.name() != "priority-rule" || !xmlReader.isEndElement()) {
@@ -87,20 +100,26 @@ QMap<QString, int> PortalConfigResponse::parsePriorityRules(QXmlStreamReader &xm
             priorityRules.insert(ruleName, ruleValue);
         }
     }
+
+    PLOGI << "Finished parsing the priority rules.";
+
     return priorityRules;
 }
 
 QString PortalConfigResponse::parseGatewayName(QXmlStreamReader &xmlReader)
 {
-   while (xmlReader.name() != "description" || !xmlReader.isEndElement()) {
+    PLOGI << "Start parsing the gateway name...";
-       xmlReader.readNext();
-       if (xmlReader.name() == "description" && xmlReader.tokenType() == xmlReader.StartElement) {
-           return xmlReader.readElementText();
-       }
-   }
 
-   PLOGE << "Error: <description> tag not found";
+    while (xmlReader.name() != "description" || !xmlReader.isEndElement()) {
-   return "";
+        xmlReader.readNext();
+        if (xmlReader.name() == "description" && xmlReader.tokenType() == xmlReader.StartElement) {
+            PLOGI << "Finished parsing the gateway name";
+            return xmlReader.readElementText();
+        }
+    }
+
+    PLOGE << "Error: <description> tag not found";
+    return "";
 }
 
 QString PortalConfigResponse::userAuthCookie() const
@@ -123,27 +142,27 @@ void PortalConfigResponse::setAllGateways(QList<GPGateway> gateways)
     _gateways = gateways;
 }
 
-void PortalConfigResponse::setRawResponse(const QByteArray &response)
+void PortalConfigResponse::setRawResponse(const QByteArray response)
 {
     _rawResponse = response;
 }
 
-void PortalConfigResponse::setUsername(const QString& username)
+void PortalConfigResponse::setUsername(const QString username)
 {
     _username = username;
 }
 
-void PortalConfigResponse::setPassword(const QString& password)
+void PortalConfigResponse::setPassword(const QString password)
 {
     _password = password;
 }
 
-void PortalConfigResponse::setUserAuthCookie(const QString &cookie)
+void PortalConfigResponse::setUserAuthCookie(const QString cookie)
 {
     _userAuthCookie = cookie;
 }
 
-void PortalConfigResponse::setPrelogonUserAuthCookie(const QString &cookie)
+void PortalConfigResponse::setPrelogonUserAuthCookie(const QString cookie)
 {
     _prelogonAuthCookie = cookie;
 }

GPClient/portalconfigresponse.h

@@ -13,9 +13,9 @@ public:
     PortalConfigResponse();
     ~PortalConfigResponse();
 
-    static PortalConfigResponse parse(const QByteArray& xml);
+    static PortalConfigResponse parse(const QByteArray xml);
 
-    const QByteArray& rawResponse() const;
+    const QByteArray rawResponse() const;
     QString username() const;
     QString password() const;
     QString userAuthCookie() const;
@@ -23,8 +23,8 @@ public:
     QList<GPGateway> allGateways();
     void setAllGateways(QList<GPGateway> gateways);
 
-    void setUsername(const QString& username);
+    void setUsername(const QString username);
-    void setPassword(const QString& password);
+    void setPassword(const QString password);
 
 private:
     static QString xmlUserAuthCookie;
@@ -39,9 +39,9 @@ private:
 
     QList<GPGateway> _gateways;
 
-    void setRawResponse(const QByteArray& response);
+    void setRawResponse(const QByteArray response);
-    void setUserAuthCookie(const QString& cookie);
+    void setUserAuthCookie(const QString cookie);
-    void setPrelogonUserAuthCookie(const QString& cookie);
+    void setPrelogonUserAuthCookie(const QString cookie);
 
     static QList<GPGateway> parseGateways(QXmlStreamReader &xmlReader);
     static QMap<QString, int> parsePriorityRules(QXmlStreamReader &xmlReader);

GPClient/preloginresponse.cpp

@@ -2,6 +2,7 @@
 
 #include <QXmlStreamReader>
 #include <QMap>
+#include <plog/Log.h>
 
 QString PreloginResponse::xmlAuthMessage = "authentication-message";
 QString PreloginResponse::xmlLabelUsername = "username-label";
@@ -22,6 +23,8 @@ PreloginResponse::PreloginResponse()
 
 PreloginResponse PreloginResponse::parse(const QByteArray& xml)
 {
+    PLOGI << "Start parsing the prelogin response...";
+
     QXmlStreamReader xmlReader(xml);
     PreloginResponse response;
     response.setRawResponse(xml);
@@ -81,17 +84,17 @@ bool PreloginResponse::hasNormalAuthFields() const
     return !labelUsername().isEmpty() && !labelPassword().isEmpty();
 }
 
-void PreloginResponse::setRawResponse(const QByteArray &response)
+void PreloginResponse::setRawResponse(const QByteArray response)
 {
     _rawResponse = response;
 }
 
-bool PreloginResponse::has(const QString &name) const
+bool PreloginResponse::has(const QString name) const
 {
     return resultMap.contains(name);
 }
 
-void PreloginResponse::add(const QString &name, const QString &value)
+void PreloginResponse::add(const QString name, const QString value)
 {
     resultMap.insert(name, value);
 }

GPClient/preloginresponse.h

@@ -33,9 +33,9 @@ private:
     QMap<QString, QString> resultMap;
     QByteArray _rawResponse;
 
-    void setRawResponse(const QByteArray &response);
+    void setRawResponse(const QByteArray response);
-    void add(const QString &name, const QString &value);
+    void add(const QString name, const QString value);
-    bool has(const QString &name) const;
+    bool has(const QString name) const;
 };
 
 #endif // PRELOGINRESPONSE_H