mirror of
https://github.com/yuezk/GlobalProtect-openconnect.git
synced 2026-11-18 22:16:18 -05:00
fix(windows): restore browser auth focus and configure tunnel branding
This commit is contained in:
8 files changed
+72
-5
No files matched your search
@@ -21,6 +21,10 @@ use super::rendering_recovery::{RenderingCrash, StderrDiagnostic, eligible, is_c
|
||||
|
||||
const MAX_AUTH_RESULT_BYTES: usize = 256 * 1024;
|
||||
|
||||
#[cfg(windows)]
|
||||
/// The caller that receives foreground permission after browser authentication.
|
||||
pub const AUTH_PARENT_PROCESS_ID_ENV: &str = "GPAUTH_PARENT_PROCESS_ID";
|
||||
|
||||
pub struct SamlAuthLauncher<'a> {
|
||||
cancellation: CancellationToken,
|
||||
server: &'a str,
|
||||
@@ -197,6 +201,8 @@ impl<'a> SamlAuthLauncher<'a> {
|
||||
/// argument that never gets appended.
|
||||
fn build_command(&self, program: &Path) -> Command {
|
||||
let mut auth_cmd = Command::new(program);
|
||||
#[cfg(windows)]
|
||||
auth_cmd.env(AUTH_PARENT_PROCESS_ID_ENV, std::process::id().to_string());
|
||||
auth_cmd.arg(self.server);
|
||||
|
||||
if self.gateway {
|
||||
@@ -493,6 +499,19 @@ mod tests {
|
||||
.collect()
|
||||
}
|
||||
|
||||
#[cfg(windows)]
|
||||
#[test]
|
||||
fn auth_child_receives_its_foreground_parent() {
|
||||
let command = SamlAuthLauncher::new("portal.example.com").build_command(Path::new("gpauth"));
|
||||
let parent = command
|
||||
.as_std()
|
||||
.get_envs()
|
||||
.find(|(name, _)| *name == AUTH_PARENT_PROCESS_ID_ENV)
|
||||
.and_then(|(_, value)| value)
|
||||
.expect("the authenticator must know its foreground recipient");
|
||||
assert_eq!(parent, std::process::id().to_string().as_str());
|
||||
}
|
||||
|
||||
/// gpauth writes to the same stderr as its parent, so a caller reading the
|
||||
/// parent's JSON would hit gpauth's text records mid-stream unless the format
|
||||
/// is passed down.
|
||||
|
||||
Reference in new issue
Block a user