diff --git a/.github/workflows/desktop-icons.yaml b/.github/workflows/desktop-icons.yaml new file mode 100644 index 0000000..db469dd --- /dev/null +++ b/.github/workflows/desktop-icons.yaml @@ -0,0 +1,34 @@ +name: Desktop icon compatibility + +on: + pull_request: + paths: + - '.github/workflows/desktop-icons.yaml' + - 'scripts/tests/test_desktop_icon.py' + - 'packaging/files/usr/share/icons/**' + - 'apps/gpgui-helper/src-tauri/icons/**' + push: + branches: [main] + paths: + - '.github/workflows/desktop-icons.yaml' + - 'scripts/tests/test_desktop_icon.py' + - 'packaging/files/usr/share/icons/**' + - 'apps/gpgui-helper/src-tauri/icons/**' + +permissions: + contents: read + +jobs: + render: + strategy: + matrix: + os: [ubuntu-22.04, ubuntu-24.04] + runs-on: ${{ matrix.os }} + steps: + - uses: actions/checkout@v6 + - name: Install the distro SVG loader + run: | + sudo apt-get update + sudo apt-get install -y python3-gi gir1.2-gdkpixbuf-2.0 librsvg2-common + - name: Render desktop icons + run: /usr/bin/python3 -m unittest discover -s scripts/tests -p test_desktop_icon.py diff --git a/apps/gpgui-helper/src-tauri/icons/icon.svg b/apps/gpgui-helper/src-tauri/icons/icon.svg index bc99f0a..afcda2b 100644 --- a/apps/gpgui-helper/src-tauri/icons/icon.svg +++ b/apps/gpgui-helper/src-tauri/icons/icon.svg @@ -18,11 +18,20 @@ + - + + + + + - + + + + + diff --git a/packaging/files/usr/share/icons/hicolor/scalable/apps/gpgui.svg b/packaging/files/usr/share/icons/hicolor/scalable/apps/gpgui.svg index bc99f0a..afcda2b 100644 --- a/packaging/files/usr/share/icons/hicolor/scalable/apps/gpgui.svg +++ b/packaging/files/usr/share/icons/hicolor/scalable/apps/gpgui.svg @@ -18,11 +18,20 @@ + - + + + + + - + + + + + diff --git a/scripts/tests/test_desktop_icon.py b/scripts/tests/test_desktop_icon.py new file mode 100644 index 0000000..d466c61 --- /dev/null +++ b/scripts/tests/test_desktop_icon.py @@ -0,0 +1,49 @@ +"""Render desktop icons through the distro's GdkPixbuf/librsvg loader. + +Run with /usr/bin/python3; requires python3-gi and gir1.2-gdkpixbuf-2.0. +""" + +from pathlib import Path +import unittest + +import gi + +gi.require_version("GdkPixbuf", "2.0") +from gi.repository import GdkPixbuf + + +ROOT = Path(__file__).resolve().parents[2] +ICONS = ( + ROOT / "packaging/files/usr/share/icons/hicolor/scalable/apps/gpgui.svg", + ROOT / "apps/gpgui-helper/src-tauri/icons/icon.svg", +) + + +class DesktopIconTests(unittest.TestCase): + def test_packaged_and_helper_icons_match(self): + self.assertEqual(ICONS[0].read_bytes(), ICONS[1].read_bytes()) + + def test_icons_render_visible_artwork(self): + # Unsupported filter primitives can load successfully yet produce an + # entirely transparent icon, so successful decoding alone is not enough. + for icon in ICONS: + for size in (32, 48, 128, 256, 512): + with self.subTest(icon=icon, size=size): + pixbuf = GdkPixbuf.Pixbuf.new_from_file_at_scale( + str(icon), size, size, True + ) + self.assertEqual((pixbuf.get_width(), pixbuf.get_height()), (size, size)) + self.assertTrue(pixbuf.get_has_alpha()) + pixels = pixbuf.get_pixels() + stride = pixbuf.get_rowstride() + channels = pixbuf.get_n_channels() + visible = sum( + pixels[y * stride + x * channels + channels - 1] > 128 + for y in range(size) + for x in range(size) + ) + self.assertGreater(visible, size * size * 0.4) + + +if __name__ == "__main__": + unittest.main()