From df28072f607e5729bf33e1d25a13fc4b2adbab92 Mon Sep 17 00:00:00 2001 From: Kevin Yue Date: Sun, 15 Nov 2026 00:32:33 +0800 Subject: [PATCH] ci: report safe Windows build failure locations --- .github/workflows/build-windows.yaml | 5 ++++- scripts/private-ci-diagnostics.py | 16 ++++++++++++++++ scripts/tests/test_private_ci.py | 17 +++++++++++++++++ 3 files changed, 37 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-windows.yaml b/.github/workflows/build-windows.yaml index 6a2364a..7ec6b9c 100644 --- a/.github/workflows/build-windows.yaml +++ b/.github/workflows/build-windows.yaml @@ -139,7 +139,10 @@ jobs: -WintunDirectory (Join-Path $env:WINDOWS_BUILD_TOOLS 'wintun') ` -MakeNsis (Join-Path ${env:ProgramFiles(x86)} 'NSIS/makensis.exe') ` -OutputDirectory "$env:GITHUB_WORKSPACE/artifacts" *> $log - } catch { throw 'Windows compilation or packaging failed; private diagnostics remain on the runner.' } + } catch { + python ./.ci/scripts/private-ci-diagnostics.py compile $log + throw 'Windows compilation or packaging failed; private diagnostics remain on the runner.' + } Write-Host 'Windows compilation and packaging passed.' - name: Sign and verify update payload shell: pwsh diff --git a/scripts/private-ci-diagnostics.py b/scripts/private-ci-diagnostics.py index f6c1c58..a62f7bc 100644 --- a/scripts/private-ci-diagnostics.py +++ b/scripts/private-ci-diagnostics.py @@ -8,6 +8,18 @@ import sys def report_compile(output): + output = re.sub(r'\x1b\[[0-9;]*[A-Za-z]', '', output) + stages = re.findall(r'^GP_WINDOWS_BUILD_STAGE=(core|gui|bundle|installer)\r?$', output, re.MULTILINE) + if stages: + print(f'::error::Windows build stage: {stages[-1]}.') + locations = re.findall(r'(?:-->\s+|panicked at )([^\r\n]+?):([0-9]+):([0-9]+)', output) + for path, line, column in sorted(set(locations)): + path = path.replace('\\', '/') + for prefix in ('/source/gpgui/', '/source/gp/'): + if prefix in path: + path = path.split(prefix, 1)[1] + fingerprint = hashlib.sha256(path.encode()).hexdigest() + print(f'::error::Rust source location fingerprint: {fingerprint} {line}:{column}') codes = sorted(set(re.findall(r'error\[E[0-9]{4}\]', output))) if codes: print(f'::error::Rust diagnostic codes: {" ".join(codes)}.') @@ -17,6 +29,10 @@ def report_compile(output): 'compiler or linker killed by SIGKILL'), (r'undefined reference to|undefined symbol:', 'unresolved linker symbols'), ('proc macro panicked', 'procedural macro failed'), + (r'Review runtime license notices for|Required runtime notice is missing', + 'runtime library notices require review'), + ('Unresolved Windows runtime dependency:', 'Windows runtime dependency is missing'), + (r'out of memory|paging file is too small|os error 1455', 'memory exhausted'), ] for pattern, description in categories: if re.search(pattern, output): diff --git a/scripts/tests/test_private_ci.py b/scripts/tests/test_private_ci.py index a233748..a393b98 100644 --- a/scripts/tests/test_private_ci.py +++ b/scripts/tests/test_private_ci.py @@ -274,6 +274,23 @@ class PrivateTestStageTests(unittest.TestCase): self.assertIn(expected, result.stdout) self.assertNotRegex(result.stdout, r'(?m)^Rust tests: started') + def test_compile_diagnostics_hash_source_locations_and_allowlist_windows_stage(self): + with tempfile.TemporaryDirectory() as temporary: + log = Path(temporary) / 'private.log' + log.write_text('GP_WINDOWS_BUILD_STAGE=gui\n' + 'error[E0433]: PRIVATE_ERROR_MESSAGE\n' + ' --> D:/a/repo/source/gpgui/crates/private.rs:42:9\n' + 'PRIVATE_SOURCE_AND_CREDENTIALS\n') + result = subprocess.run([sys.executable, str(ROOT / 'scripts/private-ci-diagnostics.py'), + 'compile', str(log)], capture_output=True, text=True) + self.assertEqual(result.returncode, 0, result.stderr) + digest = hashlib.sha256(b'crates/private.rs').hexdigest() + self.assertEqual(result.stdout, + '::error::Windows build stage: gui.\n' + f'::error::Rust source location fingerprint: {digest} 42:9\n' + '::error::Rust diagnostic codes: error[E0433].\n') + self.assertEqual(result.stderr, '') + def test_test_diagnostics_hash_names_without_exposing_private_details(self): with tempfile.TemporaryDirectory() as temporary: log = Path(temporary) / 'private.log'