Release 2.3.8

Cargo.lock

@@ -579,7 +579,7 @@ dependencies = [
 
 [[package]]
 name = "common"
-version = "2.3.7"
+version = "2.3.8"
 dependencies = [
  "is_executable",
 ]
@@ -1449,7 +1449,7 @@ dependencies = [
 
 [[package]]
 name = "gpapi"
-version = "2.3.7"
+version = "2.3.8"
 dependencies = [
  "anyhow",
  "base64 0.21.5",
@@ -1485,7 +1485,7 @@ dependencies = [
 
 [[package]]
 name = "gpauth"
-version = "2.3.7"
+version = "2.3.8"
 dependencies = [
  "anyhow",
  "clap",
@@ -1506,7 +1506,7 @@ dependencies = [
 
 [[package]]
 name = "gpclient"
-version = "2.3.7"
+version = "2.3.8"
 dependencies = [
  "anyhow",
  "clap",
@@ -1528,7 +1528,7 @@ dependencies = [
 
 [[package]]
 name = "gpgui-helper"
-version = "2.3.7"
+version = "2.3.8"
 dependencies = [
  "anyhow",
  "clap",
@@ -1546,7 +1546,7 @@ dependencies = [
 
 [[package]]
 name = "gpservice"
-version = "2.3.7"
+version = "2.3.8"
 dependencies = [
  "anyhow",
  "axum",
@@ -2625,7 +2625,7 @@ dependencies = [
 
 [[package]]
 name = "openconnect"
-version = "2.3.7"
+version = "2.3.8"
 dependencies = [
  "cc",
  "common",

Cargo.toml

@@ -5,7 +5,7 @@ members = ["crates/*", "apps/gpclient", "apps/gpservice", "apps/gpauth", "apps/g
 
 [workspace.package]
 rust-version = "1.70"
-version = "2.3.7"
+version = "2.3.8"
 authors = ["Kevin Yue <k3vinyue@gmail.com>"]
 homepage = "https://github.com/yuezk/GlobalProtect-openconnect"
 edition = "2021"

changelog.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 2.3.8 - 2024-10-31
+
+- GUI: support configure the external browser to use for authentication (fix [#423](https://github.com/yuezk/GlobalProtect-openconnect/issues/423))
+- GUI: add option to remember the credential (fix [#420](https://github.com/yuezk/GlobalProtect-openconnect/issues/420))
+- GUI: fix the credential not saved issue (fix [#420](https://github.com/yuezk/GlobalProtect-openconnect/issues/420))
+- CLI: fix the default browser detection issue (fix [#416](https://github.com/yuezk/GlobalProtect-openconnect/issues/416))
+
 ## 2.3.7 - 2024-08-16
 
 - Fix the Rust type inference regression [issue in 1.80](https://github.com/rust-lang/rust/issues/125319).

crates/gpapi/src/credential.rs

@@ -194,7 +194,6 @@ impl Credential {
         Some(cred.prelogon_user_auth_cookie()),
         None,
       ),
-      // Use the empty string as the password if auth_cookie is present
       Credential::Cached(cred) => (
         cred.password(),
         None,

crates/gpapi/src/process/browser_authenticator.rs

@@ -17,9 +17,14 @@ impl BrowserAuthenticator<'_> {
   }
 
   pub fn new_with_browser<'a>(auth_request: &'a str, browser: &'a str) -> BrowserAuthenticator<'a> {
+    let browser = browser.trim();
     BrowserAuthenticator {
       auth_request,
-      browser: if browser == "default" { None } else { Some(browser) },
+      browser: if browser.is_empty() || browser == "default" {
+        None
+      } else {
+        Some(browser)
+      },
     }
   }