Compare commits

..

1 Commits

Author SHA1 Message Date
Kevin Yue
5c6a1c77f7
Fix the save credentials not working 2024-10-28 14:42:58 +00:00
2 changed files with 5 additions and 15 deletions

View File

@ -196,7 +196,11 @@ impl Credential {
),
// Use the empty string as the password if auth_cookie is present
Credential::Cached(cred) => (
cred.password(),
if cred.auth_cookie.is_some() {
None
} else {
cred.password()
},
None,
cred.auth_cookie.as_ref().map(|c| c.user_auth_cookie()),
cred.auth_cookie.as_ref().map(|c| c.prelogon_user_auth_cookie()),

View File

@ -103,20 +103,6 @@ pub async fn retrieve_config(portal: &str, cred: &Credential, gp_params: &GpPara
let client = Client::try_from(gp_params)?;
let mut params = cred.to_params();
// Avoid sending the auth cookies for the portal config API if the password is cached
// Otherwise, the portal will return an error even if the password is correct, because
// the auth cookies could have been invalidated and the portal server takes precedence
// over the password
if let Credential::Cached(cache_cred) = cred {
if cache_cred.password().is_some() {
info!("Using cached credentials, excluding auth cookies from the portal config request");
params.remove("prelogin-cookie");
params.remove("portal-userauthcookie");
params.remove("portal-prelogonuserauthcookie");
}
}
let extra_params = gp_params.to_params();
params.extend(extra_params);